Force mlaunch --csrs when "version" is 0.0.0
#576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (fake) version is commonly used when compiling development versions of the MongoDB server (via `scons MONGO_VERSION=0.0.0`) (as a way of avoiding unnecessarily rebuilding version-related object files after each commit). However, a mongod version of `0.0.0` caused `mlaunch --csrs` to exit, since (apparently) `"0.0.0" < "3.1.0"`. This prevented `mlaunch --sharded` from launching sharded clusters of current development versions of MongoDB which have been compiled this way. This change makes mlaunch use `--csrs` when the mongod version is `0.0.0`, which allows it to work correctly with all currently supported server branches (v3.2, v3.4, v3.6, master) that have been compiled with `MONGO_VERSION=0.0.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (fake) version is commonly used when compiling development versions of the
MongoDB server (via
scons MONGO_VERSION=0.0.0) (as a way of avoidingunnecessarily rebuilding version-related object files after each commit).
However, a mongod version of
0.0.0causedmlaunch --csrsto exit, since(apparently)
"0.0.0" < "3.1.0". This preventedmlaunch --shardedfromlaunching sharded clusters of current development versions of MongoDB which
have been compiled this way.
This change makes mlaunch use
--csrswhen the mongod version is0.0.0,which allows it to work correctly with all currently supported server branches
(v3.2, v3.4, v3.6, master) that have been compiled with
MONGO_VERSION=0.0.0.Description of changes
Testing
O/S testing: