Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Node Runtime #480

Merged
merged 1 commit into from
May 28, 2019
Merged

Node Runtime #480

merged 1 commit into from
May 28, 2019

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented May 9, 2019

Fix microsoft/vscode-remote-release#153.

VS Code released Remote Development recently, which allows users to connect VS Code to an isolated remote environment, e.g., ssh box, container or WSL. As remote environment is using Nodejs instead of Electron patched Nodejs, current prebuilt tree sitter binaries won't work properly.

To fix this issue

@wingrunr21
Copy link
Collaborator

I'll look at this tomorrow probably. I'll need to have a new version cut in tree-sitter-ruby first though as the prebuilt binaries won't be there until there's a new version (independent of the PR).

@wingrunr21
Copy link
Collaborator

I took a look at this over the weekend. I'll merge this and cut a release so as to at least prevent the crash, but there's going to be some additional work required to fully support remote environments.

@rebornix
Copy link
Member Author

there's going to be some additional work required to fully support remote environments

@wingrunr21 let me know if you need any information from me for the remote support.

@connorshea
Copy link
Contributor

FYI a new release of tree-sitter-ruby was cut

@wingrunr21 wingrunr21 merged commit 91c0355 into master May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby Language Server Crashes in Remote SSH Environment
3 participants