Language Server - proof of concept #366

wingrunr21 · 2018-07-04T12:18:10Z

This is a proof of concept internal language server. The server itself is opt-in and will gradually replace features in the core extension. This means if you don't like the server's features you can turn it off and go back to the current feature set.

This may not look like much but tree-sitter was a bit of a moving target. I also did a ton of research on how to implement some of the other features/problems that are currently in the extension.

Features

Parses current document on server into an AST using node-tree-sitter. This is the same experimental syntax highlighter Atom is using. This positions us quite well to support things like semantic syntax highlighting!
Balanced pair highlighting - The highlight provider will only send back highlights for balanced pairs. This is inline with the current highlighter (except this one works correctly). Next steps will be expanding the provider to highlight other language constructs (like all occurrences of methods or variables within a document)
new feature! Syntactic code folding - I implemented the proposed syntactic folding provider to allow correctly identified region folding. Next steps will be to implement the other two types of supported folds (multiline/block comments and requires).

Merge Blockers

Update documentation
Figure out best way to distribute node-tree-sitter and tree-sitter-ruby against the version of Electron VSCode is running on

wingrunr21 · 2018-07-04T12:18:55Z

I'm currently poking at the tree-sitter/tree-sitter-ruby problem via prebuild and its supportive tooling. Hopefully that's a quick fix.

wingrunr21 · 2018-07-22T18:36:39Z

Tree sitter related PRs landed this weekend. Once new releases are cut with prebuilt binaries I'll update this branch and prep a release!

numbcoder · 2018-07-26T03:46:44Z

Nice job!
Can't wait for this PR!

maxbrunsfeld · 2018-07-26T22:51:09Z

server/src/providers/ASTProvider.ts

+						oldEndPosition: this.computeEndPosition(startIndex, oldEndIndex, tree), // position in old doc change ended.
+						newEndPosition: Position.FROM_VS_POSITION(range.end).toTSPosition(), // position in new doc change ended
+					});
+					tree = this.parser.parse(text, tree);


I think that you could move this parse call out of the for loop and just parse once with the final text.

Ya that’s on my refactor list. I’m planning on building out a more robust object tree on my second pass here. Also need to figure out how to support incremental updates with the API VSCode exposes. I don’t think this is quite right

We need this to take advantage of the code folding support

This is to support the folding provider

This includes implementation updates for the new tree-sitter API

These are the minimum versions when prebuild support is available

This is to support the built-in FoldingProvider protocol + DocumentSymbol support

This now supports the FoldingProvider

wingrunr21 · 2018-08-03T14:15:41Z

Planning to merge this and cut a release this weekend

…ries

…alized

wingrunr21 mentioned this pull request Jul 4, 2018

Internal Language Server #317

Closed

6 tasks

wingrunr21 mentioned this pull request Jul 17, 2018

Outline view support #369

Closed

wingrunr21 force-pushed the language_server branch from a34710a to 1754907 Compare July 26, 2018 11:37

maxbrunsfeld reviewed Jul 26, 2018

View reviewed changes

wingrunr21 added 23 commits July 27, 2018 08:30

Remove legacy style/lint tooling

09783b0

Clean up debug server launch task

d638879

Add base tsconfig. Convert core extension config to use it.

a39ca4e

Add vscode-ruby-client

b4a288e

Add vscode-ruby-server

d430a38

Add vscode-ruby-client as dependency

1f27e2c

Ignore client/server build artifacts

9521302

Add launch configuration to attach to debug language server

bcb1ab1

Add helper scripts for the client/server compile

5f10d5d

Require a more recent version of VSCode

af56d8d

We need this to take advantage of the code folding support

Update extension version in package-lock.json

e0c147b

Add useLanguageServer configuration

eb657a6

Start build-in language server if useLanguageServer is set

7f5a388

Run prettier

ebf9d72

Increase minimum VSCode version to 1.23.0

932ac63

This is to support the folding provider

Add VSCode engine version to client

fcb22f6

Add/update dependencies for folding provider support

23c6777

Add folding range provider support

06ff703

Remove vscode and vscode-ruby-client dependencies

21531e8

Add FoldingRangeProvider with support for region folds

fa95f86

Add Folding support to CapabilityCalculator + some cleanup

e0a6d9f

Upgrade tree-sitter and tree-sitter-ruby

ca29ef9

This includes implementation updates for the new tree-sitter API

Re-enable formatOnSave

c88f730

wingrunr21 added 12 commits July 27, 2018 08:30

Add client out directory to launch extension outfiles

f5b6d36

Update minimum tree-sitter versions

07f0196

These are the minimum versions when prebuild support is available

Update VSCode engine to ^1.25

9b81ccc

This is to support the built-in FoldingProvider protocol + DocumentSymbol support

Update core extension build to support latest VSCode APIs

d098ce8

Disable the export-name tslint rule

ec0ed9f

Update to latest vscode-languageserver v4.4.0

2b591dc

This now supports the FoldingProvider

Update vscode-languageclient to get FoldingProvider support

eb2edca

Add Ruby 2.5 support to AppVeyor

1660ee8

Test on node 8.11.3 LTS

1101310

Run npm install in client and server directories

fd56e6d

Drop testing against ruby 1.9.3, 2.0.0, and 2.1.0

a064e7e

Just specify major.minor for Travis ruby versions

99f6f63

wingrunr21 force-pushed the language_server branch from b0d263d to 99f6f63 Compare July 27, 2018 14:30

wingrunr21 mentioned this pull request Aug 3, 2018

def end method highlighting does not work #372

Closed

wingrunr21 mentioned this pull request Aug 3, 2018

I can't see the end line of code #368

Closed

wingrunr21 added 12 commits August 5, 2018 06:35

Remove gulp

3a1bf61

Move sourceMap option to base tsconfig

2406cfd

Remove electron-rebuild and use prebuild-install to fetch remote bina…

c782149

…ries

Remove fold request console.log

679ddfd

Refactor server entry to support fetching prebuilt binaries on start

dd5fac5

Cleanup/order package.json scripts

8079358

Only load language server client if user has it activated

f28a8b8

Add more files to .vscodeignore

439e7f4

Add server script to clean prebuilt binaries prior to packaging

30756cd

Remove global typescript install on Travis

376d1bf

Tweak typescript version in package.json

61c2e81

Capitalize Server.ts as MacOS lied to me about it already being capit…

30dbcad

…alized

wingrunr21 merged commit f38f2b7 into master Aug 6, 2018

wingrunr21 deleted the language_server branch August 6, 2018 16:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language Server - proof of concept #366

Language Server - proof of concept #366

wingrunr21 commented Jul 4, 2018

wingrunr21 commented Jul 4, 2018

wingrunr21 commented Jul 22, 2018

numbcoder commented Jul 26, 2018

maxbrunsfeld Jul 26, 2018

wingrunr21 Jul 26, 2018

wingrunr21 commented Aug 3, 2018

Language Server - proof of concept #366

Language Server - proof of concept #366

Conversation

wingrunr21 commented Jul 4, 2018

wingrunr21 commented Jul 4, 2018

wingrunr21 commented Jul 22, 2018

numbcoder commented Jul 26, 2018

maxbrunsfeld Jul 26, 2018

Choose a reason for hiding this comment

wingrunr21 Jul 26, 2018

Choose a reason for hiding this comment

wingrunr21 commented Aug 3, 2018