Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Remove solargraph dependency and update codeCompletion and intellisense options #309

Merged
merged 6 commits into from
Mar 28, 2018

Conversation

castwide
Copy link
Contributor

@castwide castwide commented Mar 28, 2018

  • The solargraph dependency is removed.
  • ruby.codeCompletion and ruby.intellisense use false to disable rcodetools and rubyLocate respectively.
  • When rubyLocate is disabled, the ruby.reloadProject command displays informative messages.

@castwide castwide changed the title Updated codeCompletion and intellisense options Remove solargraph dependency and update codeCompletion and intellisense options Mar 28, 2018
@wingrunr21
Copy link
Collaborator

Thanks! I'll merge this once CI passes

@wingrunr21 wingrunr21 merged commit c46d0f1 into rubyide:master Mar 28, 2018
@hstove
Copy link

hstove commented Mar 31, 2018

Thanks for this change! Unfortunately I had to disable this extension because solargraph was using a lot of memory. Any plans for a version bump with this included?

@castwide
Copy link
Contributor Author

castwide commented Apr 5, 2018

@hstove Although it's still in the dependencies, the latest version of the solargraph extension should not use any resources when you disable it in the user settings. The previous version would still run a process in the background; the current version does not.

If you want to try it, make sure that both ruby.intellisense and ruby.codeCompletion are set to a value other than solargraph (none is a valid option). Let me know if it still gives you trouble.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants