Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the instrument() method more idiomatic... #328

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Make the instrument() method more idiomatic... #328

merged 2 commits into from
Jul 2, 2020

Conversation

pvdb
Copy link
Contributor

@pvdb pvdb commented Aug 6, 2019

... and fix the following Ruby warning in the process:

lib/net/ldap/instrumentation.rb:15: warning: shadowing outer local variable - payload

Doesn't change anything functionally, and the tests still pass! 😃

@pvdb pvdb mentioned this pull request Jan 23, 2020
Merged
HarlemSquirrel
HarlemSquirrel approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HarlemSquirrel HarlemSquirrel merged commit c725cd1 into ruby-ldap:master Jul 2, 2020
@pvdb
Copy link
Contributor Author

pvdb commented Jul 5, 2020

Thanks for merging!

@pvdb pvdb mentioned this pull request Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvdb @HarlemSquirrel