Add eager loading

[u2]

http://blog.plataformatec.com.br/2012/08/eager-loading-for-greater-good/
Eager loading may be greater good.

[dblock]

I definitely think we want to have this in CHANGELOG, please. Would you also care to provide some explanation of why you think this could be better?

[u2]

To be clear, the question you should be asking is: "if I don't eager load this module, when will it be autoloaded"? If the answer is: "during a request", you have to eager load it.

[dblock]

I am sold ;)

[u2]

Sorry, what's the meaning of I am sold? I don't understand some English slang.
For example:

config.autoload_paths += %W(#{config.root}/extras)

# root/extras/foo.rb
class Foo
end

# root/app/models/blog.rb
class Blog < ActiveRecord::Base
end

Things are ok in development

defined?(Blog)
# => nil 
defined?(Foo)
# => nil 

Blog
# => Blog (call 'Blog.connection' to establish a connection) 
Foo
# => Foo 

defined?(Blog)
# => "constant" 
defined?(Foo)
# => "constant"

But on the production, the situation is a little different…

defined?(Blog)
# => "constant"

defined?(Foo)
# => nil

Blog
# => Blog (call 'Blog.connection' to establish a connection) 
Foo
# => Foo 

defined?(Blog)
# => "constant" 
defined?(Foo)
# => "constant"

Even before we try to use Blog for the very first time, the class is already loaded and the constant is known. Why is that so? Because of eager loading.

[u2]

:), I will add CHANGELOG later.

[dblock]

"I am sold" means "you sold me the reason to do this", which means "I agree with this change because your argument makes sense". So yes, update CHANGELOG and we're good to go.

[u2]

updated.

[dblock]

Put this back please?

[u2]

ok.

[dblock]

Merged.