Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace support options argument, only requirements options now #363

Merged
merged 1 commit into from
Mar 12, 2013
Merged

namespace support options argument, only requirements options now #363

merged 1 commit into from
Mar 12, 2013

Conversation

niedhui
Copy link
Contributor

@niedhui niedhui commented Mar 12, 2013

fix issue #320 .

dblock
dblock reviewed Mar 12, 2013
View reviewed changes
spec/grape/endpoint_spec.rb
@@ -273,6 +274,36 @@ def app; subject end
get 'rodzyn@test.com/wrong_middle/1'
last_response.status.should == 404
end

context ' namespace requirements' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after the quote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Will be more careful next time

@dblock dblock merged commit 19bbe75 into ruby-grape:master Mar 12, 2013
@dblock
Copy link
Member

dblock commented Mar 12, 2013

Merged, thank you. I made those small changes.

@niedhui niedhui deleted the namespce_requirements branch March 13, 2013 13:50
@dblock dblock mentioned this pull request Apr 14, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niedhui @dblock @fgfm999