-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to_xml method options in the default error_formatter #290
Conversation
I think it makes sense.
|
Okay, i will add these changes a bit later. |
I'm added specs and changelog entry. I didn't have anything to add to the documentation to be honest. Oh, to_s on hash instance behaves differently in 1.8 and 1.9 :( |
end | ||
get '/' | ||
last_response.body.should == {:message=>"rain!"}.to_s | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused. How is this XML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The object don't respond to the to_xml method, what you see is the output of to_s. For testing to_xml we need to add active_support and builder(/~https://github.com/lifo/docrails/blob/master/activesupport/lib/active_support/builder.rb) into dependencies, the question is should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if we want to test XML, we definitely should!
Sorry for al those messy commits. Now we have proper xml in the test and successfull build. |
This is good, thanks, merging. |
Change to_xml method options in the default error_formatter
Changes Unknown when pulling 7984e1f on dpsk:master into * on intridea:master*. |
Changes Unknown when pulling 7984e1f on dpsk:master into * on intridea:master*. |
Changes Unknown when pulling 7984e1f on dpsk:master into * on intridea:master*. |
I think it's better to have something like this
instead of:
hash as root looks a little off.