Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require logger for concurrent-ruby 1.3.5 #2525

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Require logger for concurrent-ruby 1.3.5 #2525

merged 4 commits into from
Jan 20, 2025

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Jan 19, 2025 •
edited
Loading

This breaks ActiveSupport 6.1 and 7.0. Requiring logger before active_support fixes the issue

@grape-bot
Copy link

grape-bot commented Jan 19, 2025 •
edited
Loading

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@ericproulx ericproulx marked this pull request as ready for review January 19, 2025 20:48
@ericproulx ericproulx requested a review from dblock January 19, 2025 20:58
@dblock dblock merged commit 926c28d into ruby-grape:master Jan 20, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericproulx @grape-bot @dblock