Add ruby 3.3 to edge and test flows #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update actions/checkout to v4 Remove a spec not related to endpoint method missing
Generated by 🚫 Danger |
dblock
reviewed
Jan 2, 2024
| get '/hey' | ||
| end.to raise_error(NoMethodError, /^undefined method `x' for #<Object:0x[0-9a-fA-F]+>$/) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
What's the reason for removing this? It was fixing a bug I believe with failure context.
There was a problem hiding this comment.
Well, it works for the endpoint through themethod_missing but otherwise, the NoMethodError is handled by the object it self. Also when you look at the code, its supposed to end with in /hey' endpoint` but it does not. We don't have the control over all the instances declared in the endpoint but we do at the endpoint's instance level.
dblock
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ruby 3.3 is our GH workflows.