refactored the full_messages method and stop overriding full_message #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
with this I'm getting rid of `full_message` method which in ruby 2.5 returns a formatted string of the error. https://ruby-doc.org/core-2.5.0/Exception.html#full_message-method
hosseintoussi
force-pushed
the
refactor_full_messages_method
branch
from
8b2b689 to
918ad55
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thank you for your work here 🙏.
This PR is an attempt to address: #1954.
As mentioned in the issue, Ruby 2.5 add a
full_messageto Exception (https://ruby-doc.org/core-2.5.0/Exception.html#full_message-method). Grape overrides this and to stop that this PR removes thefull_messageprivate method.