New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test_with option to values validator #1568

Merged

dblock merged 1 commit into ruby-grape:master from jlfaber:check_with

Feb 1, 2017

Contributor

jlfaber commented Jan 31, 2017

This PR adds a new option test_with to the values validator. If present, it must be a Proc that accepts a single argument (the param value) and returns a truthy value if the argument is valid.

I don't think this has been explicitly asked for, and one could certainly do the same thing using a custom validator. But this seemed a little more convenient for simple validations that aren't already handled by the existing built-ins.

This could be an acceptable workaround/solution for #1535 which requests the ability to specify a maximum parameter value.

Member

dblock commented Jan 31, 2017 •

edited

Loading

Quick thought. Maybe test_with could be compare_with or proc?

coveralls commented Jan 31, 2017 •

edited

Loading

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

12 similar comments

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

coveralls commented Jan 31, 2017

Coverage decreased (-0.007%) to 99.067% when pulling a354dbd on jlfaber:check_with into 081d09b on ruby-grape:master.

Contributor Author

jlfaber commented Feb 1, 2017

Fair point. Not in love with compare_with as it's not necessarily a compare. I kind of like proc though. I'll tweak that and repush.


          Add proc option to values validator

5d520ba

jlfaber force-pushed the check_with branch from a354dbd to 5d520ba Compare

February 1, 2017 00:28

coveralls commented Feb 1, 2017 •

edited

Loading

Coverage increased (+0.03%) to 99.104% when pulling 5d520ba on jlfaber:check_with into 081d09b on ruby-grape:master.

Contributor Author

jlfaber commented Feb 1, 2017

Renamed test_with to proc and cleaned up some unused test code to (slightly) improve coverage.

dblock merged commit d124df7 into ruby-grape:master

Member

dblock commented Feb 1, 2017

Looks great, merged.

jlfaber deleted the check_with branch

February 1, 2017 16:20

jlfaber mentioned this pull request

Parameter maximum value #1535

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet