Support inserting middleware before/after anonymous classes in the middleware stack #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Grape::Middleware::Error` is inserted in the middleware stack as `Class.new(Grape::Middleware::Error)`, we cannot rely on comparing classes directly when trying to insert around this middleware. We need to take into account the superclass, for anonymous classes only.
| 0.17.0 (7/29/2016) | ||
| ================== | ||
|
|
||
| #### Features | ||
|
|
||
| * [#1393](/~https://github.com/ruby-grape/grape/pull/1393): Middleware can be inserted before or after default Grape middleware - [@ridiculous](/~https://github.com/ridiculous). | ||
| * [#1390](/~https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@Rosa](/~https://github.com/Rosa). | ||
| * [#1390](/~https://github.com/ruby-grape/grape/pull/1390): Allow inserting middleware at arbitrary points in the middleware stack - [@rosa](/~https://github.com/rosa). |
There was a problem hiding this comment.
I took the chance to change that to lowercase, I realised I had used uppercase when that PR had already been merged 😅
|
This is perfect, thanks. |
|
Thanks for the super quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that this commit broke usages of
insert_before/insert_afterwithGrape::Middleware::Error. For example, this is how I use it:Since that commit,
Grape::Middleware::Erroris inserted in the middleware stack asClass.new(Grape::Middleware::Error). Then, when we try to insert another middleware before or after it, we get:The reason is that we don't recognize the anoymous class that represents
Grape::Middleware::Errorin the stack. This pull-request allows considering the superclass for anonymous classes when comparing middleware within the stack. Feel free to suggest a different way to approach this problem, this was just my personal attempt to fix it in a simple way.