Fix #1348: global functions called during mount. #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
global-namespace-function
branch
from
1d83032 to
5238f3a
Compare
dblock
changed the title
| def namespace | ||
| attributes.namespace | ||
| end | ||
|
|
There was a problem hiding this comment.
Seems that a different implementation takes precedence over def_delegators.
dblock
force-pushed
the
global-namespace-function
branch
from
5238f3a to
15a5acf
Compare
| true | ||
| else | ||
| @attributes.key?(m) | ||
| end |
There was a problem hiding this comment.
You may want to define respond_to_missing? for this class (https://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding)
dblock
force-pushed
the
global-namespace-function
branch
from
15a5acf to
c887607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348.
A globally defined
def namespacein Ruby 2.3.0 pollutes OStruct instance methods. This is described in https://bugs.ruby-lang.org/issues/12136 and https://bugs.ruby-lang.org/issues/12251. One way to reproduce this is toinclude Rake::DSLin the global scope, which defines a globalnamespacemethod.This PR gets rid of the OStruct. We cannot use a
Hashhere because we want to respond to methods like.indexwhich are natively defined on aHash, so we need a dummy structure that responds to anything. Because it behaves like a Hash though we don't need to register parameters or such, cc: @namusyaka in case I missed anything.