Use formatters for custom vendored content types. #1185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using custom vendored content types the specified formatters were not being used because only the generalized type was being made available to match.
Grape::Middleware::Formatter#mime_array
- when provided with accept headerapplication/vnd.mycompany.upcase+txt
- has previously returnedand now returns
This allows
Grape::Middleware::Formatter#format_from_header
to match the custom type and proceed to use the custom formatter.Example