Makes #declared unavailable to before filters #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to issue ruby-grape#1074 This adds a mechanism by which Grape::DSL::InsideRoute methods may be overriden after certain filters are run. The first problem case of a filter being utilized before it should that necessitated this enhancement is the `#declared` method, which was returning un-coerced params in `before` filters. There may be other problem cases, which may be rectified using this same mechanism.
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| # A filtering method that will return a hash |
There was a problem hiding this comment.
It's a little weird to have the docs on the method stub rather than the full version in the PostBeforeFilter module. Anyone more savvy with YARD know if this is the best way to be doing this?
|
Please do fix the build, thx. |
|
Sorry about that. Didn't realize Rubocop was doing its thing. Should be good now. |
|
This looks good, mind squashing the commits please? |
|
Needs a CHANGELOG entry and I think something in UPGRADING that says if you used this method before it will now raise ... |
jrforrest
force-pushed
the
bugfix/declared_scope
branch
3 times, most recently
from
a2acb8e to
ef2948f
Compare
|
Squashed, and updated CHANGELOG and UPGRADING docs. |
dblock
added a commit
that referenced
this pull request
Sep 3, 2015
Makes #declared unavailable to before filters
|
Merged, thanks. |
|
Sure thing. Thank you for the thorough review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #1074
This adds a mechanism by which Grape::DSL::InsideRoute methods may be
overriden after certain filters are run.
The first problem case of a filter being utilized before it should that
necessitated this enhancement is the
#declaredmethod, which wasreturning un-coerced params in
beforefilters.There may be other problem cases, which may be rectified using this same
mechanism.