Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Layout/AccessModifierIndentation #13298

Conversation

koic
Copy link
Member

@koic koic commented Oct 5, 2024

This PR fixes the following infinite loop error for Layout/AccessModifierIndentation when the access modifier is on the same line as the class definition.

$ echo 'class A; private; def foo; end; end' | bundle exec rubocop --stdin dummy.rb -a --only Layout/AccessModifierIndentation
(snip)

Infinite loop detected in /Users/koic/src/github.com/rubocop/rubocop/dummy.rb and caused by Layout/AccessModifierIndentation
Hint: Please update to the latest RuboCop version if not already in use, and report a bug if the issue still occurs on this version.
Please check the latest version at https://rubygems.org/gems/rubocop.
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/runner.rb:322:in 'block in RuboCop::Runner#iterate_until_no_changes'
<internal:kernel>:191:in 'Kernel#loop'

In cases like this, where they are on the same line, the concept of indentation doesn't apply, so it can be ignored.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following infinite loop error for `Layout/AccessModifierIndentation`
when the access modifier is on the same line as the class definition.

```console
$ echo 'class A; private; def foo; end; end' | bundle exec rubocop --stdin dummy.rb -a --only Layout/AccessModifierIndentation
(snip)

Infinite loop detected in /Users/koic/src/github.com/rubocop/rubocop/dummy.rb and caused by Layout/AccessModifierIndentation
Hint: Please update to the latest RuboCop version if not already in use, and report a bug if the issue still occurs on this version.
Please check the latest version at https://rubygems.org/gems/rubocop.
/Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/runner.rb:322:in 'block in RuboCop::Runner#iterate_until_no_changes'
<internal:kernel>:191:in 'Kernel#loop'
```

In cases like this, where they are on the same line, the concept of indentation doesn't apply, so it can be ignored.
@bbatsov bbatsov merged commit 6ac77fb into rubocop:master Oct 6, 2024
22 checks passed
@koic koic deleted the fix_an_error_for_layout_access_modifier_indentation branch October 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants