Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlighting for fastlane files #976

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Add highlighting for fastlane files #976

merged 3 commits into from
Jul 3, 2019

Conversation

remcohaszing
Copy link
Contributor

@pyrmont
Copy link
Contributor

pyrmont commented Jul 3, 2019

@remcohaszing I'm sorry it's taken so long to get back to you (especially on what is a very simple addition). I've resolved the merge conflicts with the current Ruby lexer but could you add some tests to the spec for these filename globs? The tests would go here:

it 'guesses by filename' do
assert_guess :filename => 'foo.rb'
assert_guess :filename => 'foo.ruby'
assert_guess :filename => 'foo.rbw'
assert_guess :filename => 'foo.gemspec'
assert_guess :filename => 'foo.podspec'
assert_guess :filename => 'Rakefile'
assert_guess :filename => 'Guardfile'
assert_guess :filename => 'Gemfile'
assert_guess :filename => 'foo.rake'
assert_guess :filename => 'Capfile'
assert_guess :filename => 'Podfile'
assert_guess :filename => 'Vagrantfile'
assert_guess :filename => 'config.ru'
assert_guess :filename => 'foo.pdf.prawn'
assert_guess :filename => 'Berksfile'
end

And yes, we're missing a few tests but I'll add those through a separate PR.

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label Jul 3, 2019
@pyrmont pyrmont merged commit da7f4dd into rouge-ruby:master Jul 3, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 3, 2019

Thanks for adding these, @remcohaszing!

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants