Move common rules to common module for TypeScript lexer #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix the problem referred to in #1516 where the TypeScript and TSX lexers treat optional chaining differently. |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
…uby#1530) The TypeScript lexer was refactored in a previous commit to move its memoisation methods into a module that could be mixed in by the TSX lexer. This is because the TSX lexer needs to inherit from both the TypeScript lexer and the JSX lexer but can't do that direclty because Ruby does not support multiple inheritance. While the memoisation methods were moved, changes to states of TypeScript lexer were not refactored out. This means that the TypeScript and TSX lexers can lex the same code differently. This commit fixes that problem by adopting the same approach used with the ObjectiveC common module: using Ruby's `Module#extended` hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the TSX lexer needs to inherit from both the TypeScript lexer and the JSX lexer (and because Ruby does not have multiple inheritance), most of the TypeScript lexer was extracted into a common module.
Some rules were not moved, though and this caused differences in the output from the TypeScript and TSX lexers that were not correct. This fixes that problem by adopting the same approach used with the ObjectiveC common module: using Ruby's
Module#extendedhook.