Fix: q lexer - escaped quote within strings not being recognised #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inside. Added more examples to the demo file.
|
Thanks for the fix, @AngusWilson! The next release of Rouge will come out on Tuesday and this will be part of that release 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current lexer would recognise the escaped quote within
"\""as the end of the stringThis caused files with any escaped quotes to be treated as a string from there onward and have no further syntax highlighting.
New rule on line 113 ahead of the pop checks that the quote is not escaped before terminating the string.
See updated example below.
Old:
New:
