Dockerfile Naming Convention | Edge Case #1070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our team uses a different naming convention - Dockerfile_1.0
Added `*.Dockerfile`
|
@sethbergman There's another one that covers parts of this (#1059). I think once #1062 (to fix the CI) has been sorted out, we should make sure to look at solving both of these cases too. Just waiting for one of the maintainers to have time to get those earlier bits cleared out. |
|
@vidarh thanks for the update! |
Removed specific bundler version
|
@sethbergman Sorry it's taken a while to get back to you on this :( Would you be able to do force push to kick off a fresh CI cycle? You should be able to do something like: $ git commit --amend
$ git push --force |
pyrmont
added
the
author-action
pyrmont
removed
the
author-action
|
@sethbergman Sorry for the flood of notifications! A similar PR, #1059, has incorporated your tweaks and been merged in. Thanks for your help! |
|
@pyrmont that's great! Thanks for letting me know! |
pyrmont
added a commit
that referenced
this pull request
Jul 4, 2020
In addition to adding the `*.Dockerfile` file glob, #1059 added a file glob for `Dockerfile_*` to address #1070. However, as noted by #1539, this causes issues for files that begin with `dockerfile_` but that are not Dockerfiles. Adding the `Dockerfile_*` file glob was an error and this commit removes it. It is a non-standard name and is not recognised by other syntax highlighting libraries (e.g. Pygments, Chroma, Linguist). The correct fix for the issue that precipitated #1070 is to use a `.gitattributes` file.
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
In addition to adding the `*.Dockerfile` file glob, rouge-ruby#1059 added a file glob for `Dockerfile_*` to address rouge-ruby#1070. However, as noted by rouge-ruby#1539, this causes issues for files that begin with `dockerfile_` but that are not Dockerfiles. Adding the `Dockerfile_*` file glob was an error and this commit removes it. It is a non-standard name and is not recognised by other syntax highlighting libraries (e.g. Pygments, Chroma, Linguist). The correct fix for the issue that precipitated rouge-ruby#1070 is to use a `.gitattributes` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if this would be useful in your project. I found that GitLab uses it and thought I'd attempt to contribute. I've since found a workaround for syntax highlighting in our
Dockerfile_1.11.1type naming convention. Let me know if I've missed something and I'd be happy to commit more to this awesome project!