Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use standard way to find version #51

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: use standard way to find version #51

merged 1 commit into from
Jul 19, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 19, 2024

Example: /~https://github.com/ropensci/GSODR/blob/7404aca8b9b258be473985e5fce39291f9814606/inst/CITATION#L9

With this change, {codemeta} will be able to read the CITATION file when the package is not installed, which is what happens when we try to build rOpenSci registry.

Once you merge this, the daily registry build from /~https://github.com/ropensci/roregistry should include your package.

cc @jeroen

@jeroen
Copy link
Member

jeroen commented Jul 19, 2024

This line with R package version gets automatically generated by the citation() function, I think it is better to remove it alltogether. This way citation("osmapiR") will automatically include the current version.

Copy link
Collaborator

@jmaspons jmaspons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good and works as expected

@jmaspons
Copy link
Collaborator

This line with R package version gets automatically generated by the citation() function, I think it is better to remove it alltogether. This way citation("osmapiR") will automatically include the current version.

I would like to, but the current citation implementation doesn't add the DOI from CRAN. Looking at the citation() code and the meta$Repository content seems easy to add. Perhaps I'll try to propose the patch, @jeroen

@jmaspons jmaspons merged commit 7ac6a43 into main Jul 19, 2024
8 checks passed
@jmaspons jmaspons deleted the maelle-patch-1 branch July 19, 2024 11:48
@jmaspons
Copy link
Collaborator

jmaspons commented Jul 19, 2024

citation() already adds DOI in R-dev (done in svn revision 86752). I will keep the file as is until JOSS publication

@maelle
Copy link
Member Author

maelle commented Jul 19, 2024

Thank you! Now, osmapiR is in the registry 🎉 ropensci/roregistry@e3fa9f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants