Update galaxy roles for Ansible 2.2 compatibility #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MailHog. This PR fixes #679, a conflict between an out-of-date MailHog galaxy role and Ansible 2.2 (also noted at discourse). Note that the latest MailHog role switches to using mhsendmail, "a sendmail replacement for MailHog," so
dev.yml
no longer needs thessmtp
role andgroup_vars/development/mail.yml
no longer needs the ssmtp variables. We could potentially move the one remaining variable togroup_vars/development/main.yml
and remove themail.yml
file.Logrotate. This PR also fixes a conflict between the logrotate galaxy role and Ansible 2.2. The out-of-date logrotate role included a "bare" variable which now fails in Ansible 2.2. This PR updates to latest logrotate role version that has this update:
NTP. This PR replaces the resmo.ntp galaxy role with the geerlingguy.ntp role, which may have a little more activity. In this latter, the task "Set the correct timezone" replaces our
common
role'stimedatectl set-timezone
command. The two tasks do the same thing. The timedatectl manpage says theset-timezone
command "will alter the /etc/localtime symlink," which is what the geerlingguy role does manually. Note: geerlingguy's role uses the variablentp_timezone
so I renamed the Trellisdefault_timezone
variable tontp_timezone
.Other roles. The PR also updates the geerlingguy.composer and geerlingguy.daemonize roles. These changes appear minor, not requiring discussion.
Tested on Ansible versions 2.0.2.0, 2.1.1.0, and 2.2.0.0