Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prestissimo from composer_global_packages #1247

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

swalkinshaw
Copy link
Member

@swalkinshaw swalkinshaw commented Oct 25, 2020

Ref #1245

Closes #1088

hirak/prestissimo is a composer plugin that speeded up composer install by downloading packages in parallel.

Composer 2.0 has been released with parallel downloading built-in and unfortunately, prestissimo is not compatible with it. Also unfortunately, Trellis auto updates composer to the latest version during provisioning. This means any provision (new or existing servers) will update to Composer 2.0 and it will fail either trying to install composer_global_packages or on deploys.

The easiest short-term solution is to remove hirak/prestissimo entirely. Anyone provisioning this change will get the latest Composer anyway (assuming they didn't customize composer_keep_updated, and if they did, they can customize composer_global_packages too).

`hirak/prestissimo` is a composer plugin that speeded up `composer install`
by downloading packages in parallel.

It's not incompatible with Composer 2.0 and not needed since 2.0 has
parallel downloading built-in.
@swalkinshaw swalkinshaw force-pushed the remove-composer-prestissimo branch from d892b18 to 9e89a07 Compare October 26, 2020 00:04
@swalkinshaw swalkinshaw merged commit d4ec2c9 into master Oct 26, 2020
@swalkinshaw swalkinshaw deleted the remove-composer-prestissimo branch October 26, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Prestissimo when Composer 2.x is released
1 participant