Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootlesskit-docker-proxy: report detailed error via FD 3 #136

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Apr 27, 2020

Fix #135


Before:

$ docker --context=rootless run -it -p 80:80 --rm alpine
docker: Error response from daemon: driver failed programming external connectiv
ity on endpoint clever_euclid (77c992ce4056362ee89727f4d2d96c349bbb9013b14f4f201
2412f2fbc94718e): Error starting userland proxy:.

After:

$ docker --context=rootless run -it -p 80:80 --rm alpine
docker: Error response from daemon: driver failed programming external connectiv
ity on endpoint brave_murdock (71e0f00b4a8555cefd15d984d15f4dc255e4caa2ca5cc72df
8a04e463afc13b2): Error starting userland proxy: error while calling PortManager
.AddPort(): cannot expose privileged port 80, you might need to add "net.ipv4.ip
_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or set CAP_NET
_BIND_SERVICE on rootlesskit binary: listen tcp 0.0.0.0:80: bind: permission den
ied.

Fix rootless-containers#135

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda merged commit c723267 into rootless-containers:master Apr 27, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Apr 27, 2020
AkihiroSuda added a commit to AkihiroSuda/docker that referenced this pull request Apr 27, 2020
Now `rootlesskit-docker-proxy` returns detailed error message on
exposing privileged ports: rootless-containers/rootlesskit#136

Full changes: rootless-containers/rootlesskit@v0.9.2...v0.9.4

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda added a commit to AkihiroSuda/docker that referenced this pull request Apr 27, 2020
Now `rootlesskit-docker-proxy` returns detailed error message on
exposing privileged ports: rootless-containers/rootlesskit#136

Full changes: rootless-containers/rootlesskit@v0.7.1...v0.9.4

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit f6ac841)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Apr 28, 2020
Now `rootlesskit-docker-proxy` returns detailed error message on
exposing privileged ports: rootless-containers/rootlesskit#136

Full changes: rootless-containers/rootlesskit@v0.9.2...v0.9.4

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Upstream-commit: f6ac84163305e8b79a22f5910004321d0b5250e2
Component: engine
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Apr 30, 2020
Now `rootlesskit-docker-proxy` returns detailed error message on
exposing privileged ports: rootless-containers/rootlesskit#136

Full changes: rootless-containers/rootlesskit@v0.7.1...v0.9.4

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit f6ac84163305e8b79a22f5910004321d0b5250e2)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Upstream-commit: 946d0ff67e1e277430ed86bd41d895eab059bab1
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rootlesskit-docker-proxy should report detailed error via FD 3
1 participant