-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Excel 2003 XML] Add support for font colors + required fixes #45
[Excel 2003 XML] Add support for font colors + required fixes #45
Conversation
Following semantic versioning, I recommend bumping a MINOR version, to However -- there may be users depending on the mis-parsing of the cells, especially row and column numbers around merged cells. Therefore, you may need to bump a MAJOR version, to Does that make sense? Depends how you all are thinking about it. |
@Empact et all -- any chance of getting eyes on this PR? |
This looks great. Thanks! Keep the PRs coming. :) |
Hurray! Thanks @Empact. I might try to tackle the streaming api question, now that you mention it. In the meantime -- our team would really appreciate it if you could cut a gem release that contains this PR? Cheers! -Marc |
Ping on request for a |
@ms-ati Released! Could you give it a try? https://rubygems.org/gems/roo-xls/versions/1.2.0 Also a github release /~https://github.com/roo-rb/roo-xls/releases/tag/v1.2.0 |
Nice @Empact ! Thank you :) |
As mentioned in #42, all I'd needed was to add support for the color of a given cell. But unfortunately, I discovered that other pieces of the puzzle were broken along the way.
This PR attempts to fix all that, adding the support for fonts and colors via
#font
.Adds RSpec coverage via the following test files (screenshot included for those without Excel):
font_colors.xml.zip
Fixes #41, #42, #43, #44
Also fixes #33 I believe