Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unified Integer class in 2.4+ #34

Merged
merged 1 commit into from
May 14, 2017
Merged

Support unified Integer class in 2.4+ #34

merged 1 commit into from
May 14, 2017

Conversation

alpaca-tc
Copy link
Contributor

Fixes deprecation warnings in Ruby2.4
roo-xls/lib/roo/xls/excel.rb:144: warning: constant ::Fixnum is deprecated

@coveralls
Copy link

coveralls commented Feb 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 79.795% when pulling 71504df on alpaca-tc:support_unified_integer_class into 6449b5d on roo-rb:master.

@jastkand
Copy link
Contributor

@stevendaniels can we somehow force this to be merged, please?

@Empact Empact merged commit 3ed9959 into roo-rb:master May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alpaca-tc @coveralls @jastkand @Empact