feature(rome_js_analyzer): semantic rules and "no arguments" lint rule

[xunilrj]

This PR creates the foundation and implements the first semantic/scoping rule of #2743. Undoubtedly the SemanticModel will need improvements. We can do them as we see need from the rules.

Relevant changes

Query return node directly

 let node = ctx.query(); //instead of  let Ast(node) = ctx.query();

Semantic model is accessed through RuleContext

but the method model() exist only if the Rule asked for the semantic model.

let reference = ctx.query();

let name = reference.syntax().text_trimmed();
if name == "arguments" {
    let model = ctx.model();
    ...
}

New query type

Rules can ask to run with the semantic model with

type Query = Semantic<JsReferenceIdentifier>;

rome_js_analyze run the in two phases

Today everything is run serially. But the opportunity to run in MT is right there!
I did a quick test and the only major problem I saw was Rc inside rome_rowan.

pub fn analyze<F, B>(...) {
    // Phase Syntax
    // Phase Semantic
}

performance

Speed is almost the same without the semantic model. I saw a minor increase (1/2ms) in the input.js of the rome_cli folder.

As soon as we land more semantic lint rules, we can focus on optimization.

playground

I added two small improvements to the playground.
First, colors!

Second, timing:

this time in on the debug build. I am not good to advertise features! 😄

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	3273f98
Status:	✅  Deploy successful!
Preview URL:	https://af7eca51.tools-8rn.pages.dev
Branch Preview URL:	https://feature-no-arguments.tools-8rn.pages.dev

View logs

[github-actions]

Parser conformance results on ubuntu-latest

js/262

Test result	main count	This PR count	Difference
Total	45878	45878	0
Passed	44938	44938	0
Failed	940	940	0
Panics	0	0	0
Coverage	97.95%	97.95%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	39	39	0
Passed	36	36	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.31%	92.31%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	5946	5946	0
Passed	388	388	0
Failed	5558	5558	0
Panics	0	0	0
Coverage	6.53%	6.53%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	588	588	0
Passed	519	519	0
Failed	69	69	0
Panics	0	0	0
Coverage	88.27%	88.27%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	16257	16257	0
Passed	12393	12393	0
Failed	3864	3864	0
Panics	0	0	0
Coverage	76.23%	76.23%	0.00%

[github-actions]

Playground for commit f424863

[ematipico]

@xunilrj there's an empty file that is not supposed to be there. It's called services.rs

[IWANABETHATGUY]

Are these comments still needed?

[xunilrj]

No. Good catch.