Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BuildMock to MockQueryable.EntityFrameworkCore #77

Closed
skarllot opened this issue May 21, 2024 · 4 comments
Closed

Move BuildMock to MockQueryable.EntityFrameworkCore #77

skarllot opened this issue May 21, 2024 · 4 comments

Comments

@skarllot
Copy link

Move the extension method BuildMock to the package MockQueryable.EntityFrameworkCore.
@romantitov
Copy link
Owner

Hello @skarllot could you provide more detailed reason why this change should be done?

@skarllot
Copy link
Author

Because it does not depend on NSubstitute but only on the TestAsyncEnumerableEfCore class defined in MockQueryable.EntityFrameworkCore, it would allow sharing the implementation regardless of the mocking library used, and furthermore, allow using no mocking library at all if the user desires.

romantitov added a commit that referenced this issue Aug 20, 2024
@romantitov
v7.0.2
052842b 
#77 BuildMock moved to MockQueryable.EntityFrameworkCore - Thanks @skarllot
@romantitov
Copy link
Owner

Done in v7.0.2

@romantitov romantitov mentioned this issue Aug 23, 2024
Closed
@scp-mb
Copy link

scp-mb commented Aug 23, 2024

Breaking change on a patch version? Not cool. Why not release is at 8.0.0 if it's got a breaking change in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skarllot @romantitov @scp-mb