Reduce the retained memory when defining the relation readers

[DangerDawson]

Fixes: #694

[solnic]

LGTM thanks for working on this!

[solnic]

@DangerDawson seems like repository specs are now failing :/ looks like "Optimise the repository relations reader" is the culprit.

[DangerDawson]

It looks as though it is something to do with the way I am caching the `build_relation_readers` in the class attribute. I will try and carve sometime out over the weekend to understand what is going on, bit it feels like state leaking between the specs as the specs that fail pass when they are ran individually

…

On 2 Aug 2024, at 15:21, Peter Solnica ***@***.***> wrote: @DangerDawson </~https://github.com/DangerDawson> seems like repository specs are now failing :/ looks like "Optimise the repository relations reader" is the culprit. — Reply to this email directly, view it on GitHub <#695 (comment)>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/AAARNDCV2NZNIY2BGUKHUPTZPOIU7AVCNFSM6AAAAABLF6C6LOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGUYDGNJRGM>. You are receiving this because you were mentioned.

[solnic]

Yeah that's what I suspected. We can have an after callback that clears the cache in RSpec.

[DangerDawson]

This is probably not the most elegant way, maybe using dry configurable and having a callback reset the class attributes back to their defaults would be nicer. But I wanted provide a fix ASAP in order to get the branch green again:

#696