Turn Plugins module into global plugins container #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
improve-plugin-setup
branch
from
80a0082 to
cfa4e5b
Compare
This is now less code and it's consistent with components registry
solnic
force-pushed
the
improve-plugin-setup
branch
from
cfa4e5b to
d79a8c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make things consistent and simpler, this renames
ROM.plugins_registrytoROM.pluginswhich is just a shortcut for for accessingROM::Pluginsand it also exposes plugin configuration/registration DSL. It's consistent withROM.componentsnow and we no longer need an additional "registry" class (so, less code).