Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin setup #639

Merged
merged 1 commit into from
Jun 27, 2021
Merged

Improve plugin setup #639

merged 1 commit into from
Jun 27, 2021

Conversation

solnic
Copy link
Member

@solnic solnic commented Jun 26, 2021

Trigger listeners only for enabled plugin

Previously any plugin that would subscribe to notifications would be
always triggered, which made it impossible to isolate plugin configs

@solnic solnic added the wip label Jun 26, 2021
@solnic solnic force-pushed the improve-plugin-setup branch from fb84f65 to bd3a8c0 Compare June 26, 2021 11:49
@solnic solnic marked this pull request as ready for review June 26, 2021 11:49
@solnic solnic marked this pull request as draft June 26, 2021 11:52
@solnic solnic force-pushed the improve-plugin-setup branch from 285450d to 48020b9 Compare June 27, 2021 11:33
@solnic solnic removed the wip label Jun 27, 2021
@solnic solnic marked this pull request as ready for review June 27, 2021 11:39
@solnic solnic changed the title wip - initial work on attaching plugins to configuration notifications Improve plugin setup Jun 27, 2021
Previously any plugin that would subscribe to notifications would be
always triggered, which made it impossible to isolate plugin configs
@solnic solnic force-pushed the improve-plugin-setup branch from 48020b9 to 33652da Compare June 27, 2021 11:41
@solnic solnic merged commit 13c1de0 into master Jun 27, 2021
@solnic solnic deleted the improve-plugin-setup branch June 27, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant