Makes sure that the property of a style is not an url #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting. thanks for figuring this out! if you could rename |
…yfill. I actually got a bug with background-image property pointing to cloudfront with this url: https://d3r0d0kb2vhuxd.cloudfront.net The viewportUnitExpression regex matched the url and the url got rewritten. This is a fix to avoid that.
|
ping! not sure why there's a conflict now. |
|
the file was reindented. I resolved the conflict using the web editor (did not know this github feature existed...) thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
just had this issue that made me sweat for a while today.
Please let me know if I need to do anything else to get this PR merged.
Commit msg
I actually got a bug with background-image property
pointing to cloudfront with this url:
https://d3r0d0kb2vhuxd.cloudfront.net
The viewportUnitExpression regex matched the url
and the url got rewritten.
This is a fix to avoid that.