Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iCubGazeboV_2_5_visuomanip RGB camera port names harmonized again #196

Conversation

xEnVrE
Copy link
Contributor

@xEnVrE xEnVrE commented Mar 30, 2023

As per the title, this restore port names for the RGB cameras of iCubGazeboV_2_5_visuomanip such that they are as in

/~https://github.com/robotology/icub-models/pull/45/files#diff-1e5c2f03288ab12a5b18118bc44ed0d0096511a21c7c2e02fe851c185e3de101

and not as in

/~https://github.com/robotology/icub-models/pull/188/files#diff-e4397ef8e3fdcf273315c11bd778759f2352f511dbf53babc3c7b2b8284fa491

where the right camera port name was changed to /icubSim/cam/right by mistake.

With this change, the port names associated to the cameras are:

registration name /icubSim/cam/left/depthImage:o
registration name /icubSim/cam/left/rgbImage:o
registration name /icubSim/cam/left/rpc:i
registration name /icubSim/cam/right/rgbImage:o
registration name /icubSim/cam/right/rgbImage:o/rpc

i.e., different from the real robot, as documented in #47, but at least harmonized.

Fixes #195

cc @traversaro @pattacini @davidegorbani

@traversaro
Copy link
Member

Can you add a changelog note?

@xEnVrE
Copy link
Contributor Author

xEnVrE commented Mar 30, 2023

Can you add a changelog note?

Done!

@traversaro
Copy link
Member

Thanks!

@traversaro traversaro merged commit d6e68d3 into robotology:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right camera port does not open on iCubGazeboV2_5_visuomanip model
3 participants