Added the lastBaseline property to LayoutProxy #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliaCereda
force-pushed
the
last-baseline
branch
from
98586cc to
5f1105f
Compare
|
Thanks for the Pull Request 💖 Would you mind adding a test that verifies the intended behavior? |
|
Alright, let me look into it. ;) Elia Cereda
|
|
Looking at the code, I don't see any test for |
|
Fair enough, let's leave this for future generations to worry about ¯_(ツ)_/¯ |
robb
added a commit
that referenced
this pull request
Dec 12, 2015
Added the lastBaseline property to LayoutProxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutProxydidn't have a property forNSLayoutAttribute.LastBaselineso I added it myself. Or is there a reason for why it's missing?I tested the code in my application and it looks like it's working.