Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying live validation with numeric prefixes #958

Closed
2 tasks done
Y-Less opened this issue Jun 20, 2018 · 3 comments · Fixed by #1183
Closed
2 tasks done

Annoying live validation with numeric prefixes #958

Y-Less opened this issue Jun 20, 2018 · 3 comments · Fixed by #1183
Labels

Comments

@Y-Less
Copy link

Y-Less commented Jun 20, 2018

Prerequisites

  • I have read the documentation;
  • In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

When live validation is enabled, typing in a negative number will flash up a warning for a moment when typing in negative numbers. I.e. after having typed only the - of -2, the live validation will complain that the input should be an integer, despite the fact that that is a valid integer prefix.

The same goes for typing . in front of a number. For a moment the warning flashes up then vanishes, which can be very annoying depending on the type of warning issued.

Steps to Reproduce

  1. Add an integer field.
  2. Press -.
  3. Press another number.

Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Expected behavior

Ignore - and . when they are the only characters in an integer or number field, defer checking that they are the only character till form submission instead.

Actual behavior

Flashing warnings.

Version

You can usually get this information in your package.json or in the file URL if you're using the unpkg one.

@epicfaace
Copy link
Member

Reproducible JSFiddle: https://jsfiddle.net/epicfaace/t329bLn0/

@epicfaace epicfaace added the ux label Jan 20, 2019
@epicfaace
Copy link
Member

It's worth noting that this issue doesn't come up when ui:widget is set to updown.

@glasserc
Copy link
Contributor

glasserc commented Feb 4, 2019

This is part of a larger constellation of issues about how we handle numbers. See #674. It's also kind of a problem with how live validation works -- it probably doesn't really make sense to validate until we get a blur.

LucianBuzzo added a commit that referenced this issue Feb 15, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 15, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 25, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 26, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 26, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 26, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 26, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo added a commit that referenced this issue Feb 26, 2019
Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
epicfaace pushed a commit that referenced this issue Feb 26, 2019
)

Connects to #674 #958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
CodeGains pushed a commit to CodeGains/react-jsonschema-form that referenced this issue Mar 5, 2019
…sf-team#1183)

Connects to rjsf-team#674 rjsf-team#958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
sebastiancichos pushed a commit to lendingblock/react-jsonschema-form that referenced this issue Feb 20, 2020
Connects to rjsf-team#674 rjsf-team#958

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants