-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows spaced path fix #86
Conversation
…cant amount of my time
Awesome! Sorry for the delay, I've been away at a conference. In order to test this, I'm referencing this branch in my package.json like this:
That syntax throws an error. Are you aware of an easy way for me to reference this branch in package.json? |
@coryhouse this should work
|
Hrmm, still no luck. | => npm install |
@coryhouse How about this: |
@rizowski Success! The branch works with spaces in the path on Windows. 👍 One issue: With this branch, chalk coloring doesn't come through on the output. As you can see, I lost coloring after installing the branch: |
@coryhouse The color being gone is interesting. I have noticed you can reenable it by passing |
@coryhouse I am going to be gone for a couple of weeks. So I am going to pull this in without the color since, while color is nice, doesn't affect how the tool works. I will create an issue about the color and hopefully fix it while I am working on other things. |
Thanks so much for your hard work on this! |
Yeah no problem! Thanks for being a supporter! 😄 |
Fixes #84
pipe
./
if one is not provided in the optionator options.