Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix field pattern of CSR mstateen0 and hstateen0 in smstateen #1743

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

NewPaulWalker
Copy link
Contributor

In newest Release riscv-isa-release-f3f8a93-2024-11-28 , the figures of mstateen0 and hstateen0 is incorrect, missing SE0 field.

image

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, but cc @ved-rivos @bcstrongx.

@aswaterman aswaterman merged commit 58baf6d into riscv:main Dec 3, 2024
2 checks passed
@rock-ifly
Copy link

Anyone notice that mstateen0[55] is used by ssqosid extenstion, to control the access to srmcfg register

RISC-V Quality-of-Service (QoS) Identifiers (Ssqosid) Version v1.0, 2024-06-29: Ratified

If extension Smstateen is implemented together with Ssqosid, then Ssqosid also requires the bit 55
in mstateen0 introduced by Priv 1.14 to be implemented. If bit 55 of mstateen0 is 0, attempts to access
srmcfg in privilege modes less privileged than M-mode raise an illegal-instruction exception. If bit
55 of mstateen0 is 1 or if extension Smstateen is not implemented, attempts to access srmcfg when
V=1 raise a virtual-instruction exception

@NewPaulWalker
Copy link
Contributor Author

Anyone notice that mstateen0[55] is used by ssqosid extenstion, to control the access to srmcfg register

Yes, it is mentioned in the chapter about the Smstateen/Ssstateen extension in the Privileged Spec.

The P1P14 bit in mstateen0 controls access to the srmcfg CSR introduced by the Ssqosid Chapter 18 extension.

P1P14 corresponds to mstateen0[55].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants