Sscofpmf editorial fixes. #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the beginning of the descriptions of bits 58 and 59, "If set, ..." should instead be "If set and the H extension is implemented, ...". In the last paragraph, "In M and S modes, ..." should instead say "In S mode, ...".
aswaterman
reviewed
Apr 3, 2024
aswaterman
reviewed
Apr 3, 2024
src/sscofpmf.adoc
Outdated
| @@ -183,7 +183,7 @@ M-mode). | |||
|
|
|||
| Read access to bit _X_ is subject to the same mcounteren (or mcounteren and | |||
| hcounteren) CSRs that mediate access to the hpmcounter CSRs by S-mode (or | |||
| VS-mode). In M and S modes, scountovf bit _X_ is readable when mcounteren bit | |||
| VS-mode). In S modes, scountovf bit _X_ is readable when mcounteren bit | |||
There was a problem hiding this comment.
@gfavor Don't we need to say what happens in M-mode, e.g. add a sentence before this one like "In M-mode, scountovf bit X is always readable."
There was a problem hiding this comment.
Yes re scountovf. @wmat , the overall change should be replacing the "In M and S modes, ..." sentence with the following two sentences:
In M mode, scountovf bit X is always readable. In S/HS modes, scountovf bit X is readable when mcounteren bit X is set, and otherwise reads as zero.
There was a problem hiding this comment.
I've made the change as described, however, is S/HS correct? Should it be S/VS?
Suggested change
| VS-mode). In S modes, scountovf bit _X_ is readable when mcounteren bit | |
| VS-mode). In M mode, scountovf bit X is always readable, in S/HS modes, scountovf bit _X_ is readable when mcounteren bit |
gfavor
approved these changes
Apr 4, 2024
aswaterman
requested changes
Apr 4, 2024
Reworded Bits 58 & 59 description to "If set, then counting of events in VU-mode is inhibited. But if the H extension is implemented, then this bit is read-only-zero."
Updated the text for scountovf.
aswaterman
reviewed
Apr 4, 2024
aswaterman
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the beginning of the descriptions of bits 58 and 59, "If set, ..." should instead be "If set and the H extension is implemented, ...".
In the last paragraph, "In M and S modes, ..." should instead say "In S mode, ...".