Few changes before SBI v2 public review #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like other RVI specs, the pre-compiled riscv-sbi.pdf should be attached to the release tag instead of having it in spec sources. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
The 'make clean' command should remove the autogenerated directory along with build targets. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
To be consistent with other SBI extensions, let us add flags parameter to sbi_pmu_snapshot_set_shmem() function. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
We update the PMU snapshot documentation to make it consistent with other SBI extensions namely NACL and STA. In the process, we also add mechanism to disable snapshot shared memory (just like other SBI extensions). Signed-off-by: Anup Patel <apatel@ventanamicro.com>
The flags parameter of sbi_steal_time_set_shmem() should be unsigned long for consistency with sbi_nacl_set_shmem(). Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Let us adjust width of CPPC register table columns to make register IDs and names more readable. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
We will be splitting riscv-sbi.adoc into multiple adoc files so the Makefile should have a way to capture dependency. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
jones-drew
reviewed
Sep 5, 2023
riscv-sbi.adoc
Outdated
| @@ -1862,8 +1869,9 @@ The possible error codes returned in `sbiret.error` are shown in | |||
| [cols="2,3", width=90%, align="center", options="header"] | |||
| |=== | |||
| | Error code | Description | |||
| | SBI_SUCCESS | firmware counter read successfully. | |||
| | SBI_ERR_INVALID_PARAM | The `flags` parameter is not zero. | |||
| | SBI_SUCCESS | Shared memory was set or cleared successfully. | |||
jones-drew
reviewed
Sep 5, 2023
Makefile
Outdated
There was a problem hiding this comment.
How about tidying up the root directory by organizing files like the isa manual does
src/*.{adoc,ditaa}
src/images/*.png
There was a problem hiding this comment.
Also, we may now want to provide a diff.orderFile file and instructions on how to use it with git-format-patch/diff/show
There was a problem hiding this comment.
Okay, let me add sub-directories for images and sources
avpatel
force-pushed
the
sbi_v2_fixes
branch
from
e5726ac to
eb7fadd
Compare
For ease in maintainence, we split the specification into multiple adoc files under a separate src directory. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Let us move images to a dedicated directory which results in having only text files in root directory. Signed-off-by: Anup Patel <apatel@ventanamicro.com>
avpatel
force-pushed
the
sbi_v2_fixes
branch
from
eb7fadd to
84319ee
Compare
|
The series looks good to me. |
atishp04
reviewed
Sep 5, 2023
atishp04
reviewed
Sep 5, 2023
riscv-sbi.adoc
Outdated
| bitwise then `shmem_phys_lo` specifies the lower XLEN bits and `shmem_phys_hi` | ||
| specifies the upper XLEN bits of the snapshot shared memory physical base | ||
| address. The `shmem_phys_lo` MUST be 4096 bytes (i.e. page) aligned and | ||
| the size of the snapshot shared memory is assumed to be 4096 bytes. The layout |
There was a problem hiding this comment.
Should we user a normative text here ?
There was a problem hiding this comment.
This looks normative from my perspective. If required we can change text as separate patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does few changes and clean-ups before SBI v2 goes to public review.