Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set log filename extension and avoid deleting incorrect files #838

Merged
merged 3 commits into from
Mar 6, 2024
Merged

set log filename extension and avoid deleting incorrect files #838

merged 3 commits into from
Mar 6, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 6, 2024

lotem
lotem requested changes Mar 6, 2024
View reviewed changes
src/rime/lever/deployment_tasks.cc Outdated Show resolved Hide resolved
@fxliang fxliang changed the title set log filename extension and avoid deleting incorrect files set log filename extension and avoid deleting incorrect files[WIP] Mar 6, 2024
@fxliang fxliang changed the title set log filename extension and avoid deleting incorrect files[WIP] set log filename extension and avoid deleting incorrect files Mar 6, 2024
@fxliang fxliang requested a review from lotem March 6, 2024 07:03
@lotem lotem merged commit a4ed799 into rime:master Mar 6, 2024
9 checks passed
@fxliang fxliang deleted the logstuff branch March 12, 2024 05:26
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@fxliang @lotem @graphemecluster
set log filename extension and avoid deleting incorrect files (rime#838)
29646bd 
* set log filename extension ".log"

* avoid deleting non-log file or not log files of current app

---------

Co-authored-by: 居戎氏 <chen.sst@gmail.com>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@fxliang @lotem @graphemecluster
set log filename extension and avoid deleting incorrect files (rime#838)
9fab2cc 
* set log filename extension ".log"

* avoid deleting non-log file or not log files of current app

---------

Co-authored-by: 居戎氏 <chen.sst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

temp夾紀錄檔副檔名理應統一（如log）而非一堆每次不同的數
2 participants
@fxliang @lotem