Don't render preview if it's disabled #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged! |
mitya57
pushed a commit
that referenced
this pull request
Oct 8, 2020
(cherry picked from commit fa2abb5)
mitya57
pushed a commit
that referenced
this pull request
Oct 10, 2020
(cherry picked from commit fa2abb5)
mitya57
pushed a commit
that referenced
this pull request
Oct 13, 2020
(cherry picked from commit fa2abb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into that while editing files on a remote server. The preview widget's HTML is updated every time a couple characters are written, and it blocks the UI. With multiple images inside, the HTML widget tries to access all the resources as files in the current directory, hitting the drive, causing a few seconds of delay when the drive is on a high latency network. When the resources are not present (draft document), it tries again later anyway. That makes typing really annoying.
With this patch, the path to even compute the HTML is cut off, so at least typing works when the preview is disabled.
There's another problem that scrolling causes the same resource access flood when scrolling the preview, but I haven't managed to get to the bottom of it. Unfortunately, strace is limited, and neither gdb nor pdb are any useful :(