Add option to show full path in titlebar #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be a more lean solution for construct QFileInfo(self.currentTab.fileName).filePath() Option takes effect on changing tabs
|
btw -- while doing this I noticed to see the full file-path also as tab-tooltip :-) |
mitya57
requested changes
Dec 29, 2018
So do you still want this option, or a tooltip is enough? |
|
I don't urgently need this and therefore implemented with an option. |
mitya57
requested changes
Jan 8, 2019
mitya57
force-pushed
the
titleBarFullPath
branch
from
1542695 to
2455580
Compare
mitya57
force-pushed
the
titleBarFullPath
branch
from
1542695 to
1b3a056
Compare
mitya57
approved these changes
Jan 10, 2019
|
Thanks! I think “window title” is a better term than “title bar”, since it may not be actually a bar in some environments. So I changed the term, including the configuration option name, and merged. |
|
'window title' is far better and unambiguous. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a more lean solution for the construct
QFileInfo(self.currentTab.fileName).filePath()
Option takes effect on changing tabs