Do not restore sockets, correct error handling #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 52.1% 51.99% -0.12%
==========================================
Files 148 148
Lines 11712 11718 +6
==========================================
- Hits 6103 6093 -10
- Misses 4658 4678 +20
+ Partials 951 947 -4
Continue to review full report at Codecov.
|
ifedorenko
reviewed
Apr 20, 2018
| @@ -76,6 +76,11 @@ func (res *Restorer) restoreTo(ctx context.Context, target, location string, tre | |||
| continue | |||
| } | |||
|
|
|||
| // sockets cannot be restored | |||
| if node.Type == "socket" { | |||
There was a problem hiding this comment.
should backup skip sockets too?
There was a problem hiding this comment.
Yep, I've just commit this (locally) to the new-archiver branch :)
ifedorenko
approved these changes
Apr 20, 2018
fd0
added a commit
that referenced
this pull request
Apr 20, 2018
Do not restore sockets, correct error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1730