Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache dir detection #1454

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Fix cache dir detection #1454

merged 2 commits into from
Nov 29, 2017

Conversation

fd0
Copy link
Member

@fd0 fd0 commented Nov 29, 2017

This PR corrects a bug introduced just recently in the default cache dir detection for Darwin and Windows. It'll put the cache dir to ~/.cache instead of the correct location.

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #1454 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage    51.8%   51.61%   -0.19%     
==========================================
  Files         136      136              
  Lines       13760    13768       +8     
==========================================
- Hits         7128     7107      -21     
- Misses       5758     5792      +34     
+ Partials      874      869       -5
Impacted Files Coverage Δ
internal/cache/dir.go 5.88% <0%> (-0.79%) ⬇️
internal/cache/cache.go 24.77% <0%> (-0.45%) ⬇️
internal/checker/checker.go 68.31% <0%> (-3.67%) ⬇️
internal/archiver/archiver.go 65.2% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb44855...ea593fc. Read the comment docs.

@fd0 fd0 merged commit ea593fc into master Nov 29, 2017
fd0 added a commit that referenced this pull request Nov 29, 2017
@fd0 fd0 deleted the fix-cache-dir branch December 2, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants