Fix for state mutation through CLI #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by @pcholakov, state mutations fail in 0.9.0. This fixes two issues: - Propagation of the error back to the CLI - Serde HashMap<Bytes, Bytes> as Seq to get around flexbuffer's limitation Note: this needs to be cherry picked to 0.9 release. Closes #1486
tillrohrmann
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks a lot for fixing this problem so quickly @AhmedSoliman. The changes look good to me. +1 for merging and also merging it into the release-0.9 branch. Apparently, we don't have an e2e test for the state patching feature since it slipped through. I'll will file an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for state mutation through CLI
Reported by @pcholakov, state mutations fail in 0.9.0. This fixes two issues:
Note: this needs to be cherry picked to 0.9 release.
Closes #1486