-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manager/conan): allow ref with user only #26516
fix(manager/conan): allow ref with user only #26516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test on a real repo to ensure the conan
datasource can also handle this.
☝️ |
Sorry, but I still have no test environment. To test this for our use case I need a test on our local Conan and GitLab infrastructure. Is there a guide line how to setup a local test? I only found the guide line for testing on a public GitHub repo. |
Locally you can run with |
In Conan 2.x include_prerelease do not have an argument
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…into allow_conan_ref_with_user_only
where did you test this? |
We have an internal GitLab and Artifactory installation. The public Conan center packages do not have the user attribute so I needed to test it internally. |
🎉 This PR is included in version 37.132.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes
For Conan package references "user" can be used without specifying a "channel".
Now
package/1.2.3@user
is also possible.Context
see #26040
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: