Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vite): error messages when .server files are referenced by client #8267

Merged
merged 4 commits into from
Dec 12, 2023
Merged

feat(vite): error messages when .server files are referenced by client #8267

merged 4 commits into from
Dec 12, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Dec 12, 2023 •
edited
Loading

Untitled.mov

TODO

  • changeset

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 0ca4b4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/dot-server-errors branch from 906f138 to 47fd02a Compare December 12, 2023 03:03
@pcattori pcattori force-pushed the pedro/dot-server-errors branch from 47fd02a to 99bac51 Compare December 12, 2023 03:05
@pcattori pcattori force-pushed the pedro/dot-server-errors branch from 99bac51 to b534db7 Compare December 12, 2023 03:06
markdalgleish
markdalgleish approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much nicer!

@pcattori pcattori merged commit 9a845b6 into dev Dec 12, 2023
9 checks passed
@pcattori pcattori deleted the pedro/dot-server-errors branch December 12, 2023 04:55
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Dec 21, 2023
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Dec 21, 2023
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.4.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Dec 22, 2023
@gustavopch gustavopch mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcattori @markdalgleish