Restructure client route creation in preparation for client data #8090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brophdawg11
commented
Nov 21, 2023
| `to submit to it. To fix this, please add an \`action\` function to the route`; | ||
| console.error(msg); | ||
| return Promise.reject( | ||
| new ErrorResponse(405, "Method Not Allowed", new Error(msg), true) |
There was a problem hiding this comment.
loader/action here got DRY'd up into utils above that we can better compose together in a clientLoader/clientAction world
This was referenced Nov 21, 2023
Closed
jacob-ebey
approved these changes
Nov 29, 2023
Base automatically changed from
brophdawg11/deprecate-datafunctionargs
to
feature/client-data
November 29, 2023 21:03
brophdawg11
force-pushed
the
brophdawg11/2-restructure-client-routes
branch
from
df152c2 to
3595819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8089
This is the second in a series of PRs to implement Client Data into a
feature/client-databranch.This is a small reorganization of how we create client routes to make it easier to fork and add
clientLoader/clientActionlogic (in a subsequent PR). This PR shouldn't have any functional impacts.