feat(remix-dev,remix-serve): include publicPath in server build manifest

[mcansh]

this allows remix dev and remix-serve [build-dir] to use your customized assetsBuildDirectory and publicPath.

in remix dev we already read the config, so we can just pass config.publicPath and config.assetsBuildDirectory along to remix-serve's createApp function to use, but in remix-serve [build-dir] we'll require the passed buildPath in remix-serve/cli.ts and pass those from the build itself to createApp

[ryanflorence]

Looks good, we don't really have testing setup for remix-serve (in dev or production), how did you verify this all works?

Any idea why some of the tests are failing?

[mcansh]

Looks good, we don't really have testing setup for remix-serve (in dev or production), how did you verify this all works?

1. npm run playground:new
2. change publicPath and assetsBuildDirectory in remix config
3. node ./node_modules/@remix-run/dev/dist/cli.js dev
4. node ./node_modules/@remix-run/dev/dist/cli.js build
5. node ./node_modules/@remix-run/serve/dist/cli.js build

I'll reverify again just to be sure, but we could also cut an experimental just to make sure that all works as remix dev and remix-serve

Any idea why some of the tests are failing?

i changed the manifest and didn't update the snapshots 😬

[mcansh]

confirmed running locally using node ... works both in development (both remix watch and remix dev) and production

[mcansh]

published an experimental (0.0.0-experimental-6f3ef540b) and it works for both remix dev and remix-serve [build-dir]

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-de9fc05-20220712 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!